-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25100/
-----------------------------------------------------------
Review request for qpid, Justin Ross, Darryl Pierce, Rafael Schloming, and
Robbie Gemmell.
Bugs: proton-651
https://issues.apache.org/jira/browse/proton-651
Repository: qpid
Description
-------
Simple export of the version #'s. I did have to add these to the Java side,
not sure how you feel about that. I'm not comfortable updating the other
bindings - don't think I can make the best choice as to what feels 'natural'
for the other bindings.
Diffs
-----
proton/trunk/proton-c/bindings/python/proton.py 1620643
proton/trunk/proton-c/include/proton/cproton.i 1620643
proton/trunk/proton-c/include/proton/version.h.in 1620643
proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/Proton.java
1620643
proton/trunk/proton-j/src/main/resources/cproton.py 1620643
proton/trunk/proton-j/src/main/resources/cversion.py PRE-CREATION
Diff: https://reviews.apache.org/r/25100/diff/
Testing
-------
existing unit tests pass. Verified that the proton.VERSION_MAJOR/MINOR values
are correct by hand.
Thanks,
Kenneth Giusti
