> On Sept. 25, 2014, 9:22 p.m., Chug Rolke wrote: > >
I think I'll reroll the patch to a minimum 'make compile' change and leave general cleanup for later, now we're close to the RC time - bozzo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26050/#review54599 ----------------------------------------------------------- On Sept. 25, 2014, 7:10 p.m., bozzo bozzo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26050/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 7:10 p.m.) > > > Review request for qpid and Rafael Schloming. > > > Repository: qpid > > > Description > ------- > > * all files: > Reorder includes so they are always from public to private > > * platform.h: > - replace strcasecmp with !pn_i_eq_nocase > - replace strncasecmp with !pn_i_eq_n_nocase > - include winsock.h on windows > - undefine symbols 'ERROR' and 'small' that proton codebase uses. > > The openssl is actually fixed by makeing sure > the winsock.h is included before openssl headers. > > > Diffs > ----- > > proton/trunk/proton-c/src/buffer.c 1627588 > proton/trunk/proton-c/src/codec/codec.c 1627588 > proton/trunk/proton-c/src/codec/decoder.c 1627588 > proton/trunk/proton-c/src/codec/encoder.c 1627588 > proton/trunk/proton-c/src/dispatcher/dispatcher.c 1627588 > proton/trunk/proton-c/src/engine/engine.c 1627588 > proton/trunk/proton-c/src/error.c 1627588 > proton/trunk/proton-c/src/events/event.c 1627588 > proton/trunk/proton-c/src/message/message.c 1627588 > proton/trunk/proton-c/src/messenger/messenger.c 1627588 > proton/trunk/proton-c/src/messenger/store.c 1627588 > proton/trunk/proton-c/src/messenger/subscription.c 1627588 > proton/trunk/proton-c/src/messenger/transform.c 1627588 > proton/trunk/proton-c/src/object/iterator.c 1627588 > proton/trunk/proton-c/src/object/list.c 1627588 > proton/trunk/proton-c/src/object/map.c 1627588 > proton/trunk/proton-c/src/object/object.c 1627588 > proton/trunk/proton-c/src/object/string.c 1627588 > proton/trunk/proton-c/src/parser.c 1627588 > proton/trunk/proton-c/src/platform.h 1627588 > proton/trunk/proton-c/src/sasl/sasl.c 1627588 > proton/trunk/proton-c/src/scanner.c 1627588 > proton/trunk/proton-c/src/selectable.c 1627588 > proton/trunk/proton-c/src/ssl/openssl.c 1627588 > proton/trunk/proton-c/src/transport/transport.c 1627588 > proton/trunk/proton-c/src/types.c 1627588 > proton/trunk/proton-c/src/url.c 1627588 > proton/trunk/proton-c/src/util.h 1627588 > proton/trunk/proton-c/src/util.c 1627588 > proton/trunk/proton-c/src/windows/driver.c 1627588 > proton/trunk/proton-c/src/windows/io.c 1627588 > proton/trunk/proton-c/src/windows/iocp.c 1627588 > proton/trunk/proton-c/src/windows/selector.c 1627588 > proton/trunk/proton-c/src/windows/write_pipeline.c 1627588 > > Diff: https://reviews.apache.org/r/26050/diff/ > > > Testing > ------- > > compiled on windows. I'll buildtest and test all components, for now just > testing the patch process > > > Thanks, > > bozzo bozzo > >
