-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26050/
-----------------------------------------------------------

(Updated Sept. 26, 2014, 11:28 a.m.)


Review request for qpid and Rafael Schloming.


Repository: qpid


Description (updated)
-------

This is now a minimal version of the fix. No general cleanup.

* openssl.c:
   - On windows we need to include winsock before openssl headers

* platform.h:
   - define strcasecmp with !pn_i_eq_nocase
   - define strncasecmp with !pn_i_eq_n_nocase

* util.c, util.h:
   - add pn_i_eq_n_nocase
   - remove static from pn_i_eq_nocase


Diffs (updated)
-----

  proton/trunk/proton-c/src/platform.h 1627588 
  proton/trunk/proton-c/src/ssl/openssl.c 1627588 
  proton/trunk/proton-c/src/util.h 1627588 
  proton/trunk/proton-c/src/util.c 1627588 

Diff: https://reviews.apache.org/r/26050/diff/


Testing
-------

compiled on windows. I'll buildtest and test all components, for now just 
testing the patch process


Thanks,

bozzo bozzo

Reply via email to