> On Feb. 21, 2015, 1:13 p.m., Robbie Gemmell wrote: > > Checking the logs, it doesnt seem that the file was ever added. I notice > > now that the changes on QPID-6312 were applied as a single commit, whereas > > there were lots of git patches originally on the JIRA. Did you squash them > > before doing 'git svn dcommit'? Or perhaps applied them to an svn checkout > > before checking in? Possibly something went awry then. Adding the file now > > seems fine to me.
My original path of changes went from git to another machine to svn, so I probably forgot to 'add' the new file before commit. I'd like to add this to 0.32 as well. Will add Andrew for a look at this as well. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31238/#review73405 ----------------------------------------------------------- On Feb. 23, 2015, 3:56 p.m., Steve Huston wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31238/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 3:56 p.m.) > > > Review request for qpid, Andrew Stitcher, Justin Ross, and Robbie Gemmell. > > > Bugs: QPID-6312 > https://issues.apache.org/jira/browse/QPID-6312 > > > Repository: qpid > > > Description > ------- > > This file was part of the previous patches applied; I do not know why it > isn't on trunk (or on the 0.32 branch). The referencing CMakeLists.txt > changes for it did get applied, so without this file, Qpid C++ won't cmake on > AIX. I would like to merge this over to 0.32 as well. > > > Diffs > ----- > > qpid/cpp/src/qpid/sys/aix/SystemInfo.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/31238/diff/ > > > Testing > ------- > > > Thanks, > > Steve Huston > >
