----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31238/#review73645 -----------------------------------------------------------
Ship it! This looks good to me (at a fairly cursorary look), and, as it is only active on AIX, low risk. So going into 0.32 is fine by me. qpid/cpp/src/qpid/sys/aix/SystemInfo.cpp <https://reviews.apache.org/r/31238/#comment120042> Given this is AIX specific, if some versions have _SC_NPROCESSORS_ONLN and some don't then keep the #ifdef (but change the comment!). Otherwise just use the branch relevant to AIX. - Andrew Stitcher On Feb. 23, 2015, 3:56 p.m., Steve Huston wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31238/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 3:56 p.m.) > > > Review request for qpid, Andrew Stitcher, Justin Ross, and Robbie Gemmell. > > > Bugs: QPID-6312 > https://issues.apache.org/jira/browse/QPID-6312 > > > Repository: qpid > > > Description > ------- > > This file was part of the previous patches applied; I do not know why it > isn't on trunk (or on the 0.32 branch). The referencing CMakeLists.txt > changes for it did get applied, so without this file, Qpid C++ won't cmake on > AIX. I would like to merge this over to 0.32 as well. > > > Diffs > ----- > > qpid/cpp/src/qpid/sys/aix/SystemInfo.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/31238/diff/ > > > Testing > ------- > > > Thanks, > > Steve Huston > >
