[
https://issues.apache.org/jira/browse/QPID-6436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357233#comment-14357233
]
Keith Wall commented on QPID-6436:
----------------------------------
Hi Alex
A couple of comments:
# Why is
org.apache.qpid.server.model.AbstractConfiguredObject#getSecurityManager l
overridden in lots of child CO impls? Some implementations return null that
surely must NPE if authorised by the new code in ACO.
# org.apache.qpid.server.security.SecurityManager#authorise. What would the
user do with this warning? I think this represents a programming error and we
should be throwing an exception,
# org.apache.qpid.server.security.SecurityManager#authorise. The check for
RemoteReplicationNode will soon become redundant when the work on the QPID-6262
branch is merged
# org.apache.qpid.server.security.SecurityManager#isBrokerOrBrokerChild I
think this could use the BrokerModel. Low priority as SecurityManager in its
current form needs to enumerate all the model object anyway.
> [Java Broker] Move ACL functionality scattered over the configured objects
> into SecurityManager and AbstractConfiguredObjects
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-6436
> URL: https://issues.apache.org/jira/browse/QPID-6436
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Alex Rudyy
> Assignee: Keith Wall
> Fix For: 6.0 [Java]
>
> Attachments:
> 0001-QPID-6436-Java-Broker-Move-ACL-functionality-scatter.patch
>
>
> At the moment ACL checks are performed in nearly every configured object
> type. We need to encapsulate ACL checks in SecurityManager and
> AbstractConfiguredObject in order to simplify further ACL refactoring
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
