[
https://issues.apache.org/jira/browse/QPID-6436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358744#comment-14358744
]
Alex Rudyy commented on QPID-6436:
----------------------------------
Keith,
I addressed your review comments in commit under revision
[r1666212|https://svn.apache.org/r1666212]
1. Fixed potential NPE in COs
(RedirectingVirtualHostImpl,BDBHAReplicaVirtualHostImpl) by calling
super.getSecuritymanager() in overridden method getSecuritymanager()
2. WARN log is replaced with throwing of IllegalArgumentException
3. Removed check for RemoteReplicationNode
4. SecurityManager#isBrokerOrBrokerChild is renamed into
SecurityManager#isBrokerOrBrokerChildOrPreferencesProvider and
Model.getChildTypes(Broker.class).contains(category) is used to check whether
catgegory is broker children category
5. Added a check to skip authorization for SESSION/CONSUME/CONNECTION
DELETE/UPDATE and SESSION CREATE
> [Java Broker] Move ACL functionality scattered over the configured objects
> into SecurityManager and AbstractConfiguredObjects
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-6436
> URL: https://issues.apache.org/jira/browse/QPID-6436
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Fix For: 6.0 [Java]
>
> Attachments:
> 0001-QPID-6436-Java-Broker-Move-ACL-functionality-scatter.patch
>
>
> At the moment ACL checks are performed in nearly every configured object
> type. We need to encapsulate ACL checks in SecurityManager and
> AbstractConfiguredObject in order to simplify further ACL refactoring
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
