----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33194/ -----------------------------------------------------------
(Updated April 14, 2015, 9:57 p.m.) Review request for qpid and Andrew Stitcher. Repository: qpid Description (updated) ------- Previous code would incorrectly convert between float and int types producing nonsense values, and would not allow legal conversions between float and double types. Created FixedWidthIntValue and FixedWidthFloatValue template subclasses to correctly handle conversions. Enabled FieldValue unit tests for float conversions. Diffs ----- trunk/qpid/cpp/src/qpid/framing/Endian.h 1673017 trunk/qpid/cpp/src/qpid/framing/Endian.cpp 1673017 trunk/qpid/cpp/src/qpid/framing/FieldValue.h 1673017 trunk/qpid/cpp/src/qpid/framing/FieldValue.cpp 1673017 trunk/qpid/cpp/src/tests/FieldTable.cpp 1673017 trunk/qpid/cpp/src/tests/FieldValue.cpp 1673017 Diff: https://reviews.apache.org/r/33194/diff/ Testing (updated) ------- Added unit tests for float conversions. Thanks, Alan Conway
