----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33194/#review80272 -----------------------------------------------------------
Ship it! I much prefer this version - good work. - Andrew Stitcher On April 15, 2015, 9:24 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33194/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 9:24 p.m.) > > > Review request for qpid and Andrew Stitcher. > > > Repository: qpid > > > Description > ------- > > Previous code would incorrectly convert between float and int types producing > nonsense values, > and would not allow legal conversions between float and double types. > > Created FixedWidthIntValue and FixedWidthFloatValue template subclasses to > correctly > handle conversions. Enabled FieldValue unit tests for float conversions. > > > Diffs > ----- > > trunk/qpid/cpp/src/CMakeLists.txt 1673017 > trunk/qpid/cpp/src/qpid/framing/Endian.h 1673017 > trunk/qpid/cpp/src/qpid/framing/Endian.cpp 1673017 > trunk/qpid/cpp/src/qpid/framing/FieldTable.cpp 1673017 > trunk/qpid/cpp/src/qpid/framing/FieldValue.h 1673017 > trunk/qpid/cpp/src/qpid/framing/FieldValue.cpp 1673017 > trunk/qpid/cpp/src/tests/FieldTable.cpp 1673017 > trunk/qpid/cpp/src/tests/FieldValue.cpp 1673017 > > Diff: https://reviews.apache.org/r/33194/diff/ > > > Testing > ------- > > Added unit tests for float conversions. > > > Thanks, > > Alan Conway > >
