----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34809/#review85729 -----------------------------------------------------------
proton-c/bindings/python/setup.py <https://reviews.apache.org/r/34809/#comment137474> This is problematic: we're hardcoding flags for a specific compiler here (gcc). What if clang is used? Is there are way for python to figure out the compiler specific flags? proton-c/bindings/python/setup.py <https://reviews.apache.org/r/34809/#comment137475> These flags are platform-specific. I don't think we can hardcode these and expect them to work on different platforms. - Kenneth Giusti On May 29, 2015, 2:26 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34809/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 2:26 p.m.) > > > Review request for qpid, Andrew Stitcher, Dominic Evans, Gordon Sim, and > Rafael Schloming. > > > Bugs: proton-895 > https://issues.apache.org/jira/browse/proton-895 > > > Repository: qpid-proton-git > > > Description > ------- > > This change modifies the way setup.py builds and installs the Proton C > library should it not be present on the system. With this change, setup.py > builds the C library directly, rather than using cmake. The advantages to > this: > > 1) The resultant library is installed in the site-packages directory along > with proton. This allows non-root users properly install the C librarys when > doing a virtualenv or --user install. > 2) pip can be used to install/remove the entire proton stack > 3) only builds the C library - not the whole proton build > 4) no longer requires cmake, which is not part of a typical python environment > > > Diffs > ----- > > proton-c/bindings/python/setup.py 09fa76a0dd8d0f33a92f336c8d441f17748569aa > proton-c/bindings/python/setuputils/misc.py > 8978371e8ccf5e8ef5b3aa6ac99592ad8289d336 > > Diff: https://reviews.apache.org/r/34809/diff/ > > > Testing > ------- > > All python unit tests pass when run against the bindings and C library > installed with this patch. > > > Thanks, > > Kenneth Giusti > >
