-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34809/
-----------------------------------------------------------
(Updated May 29, 2015, 9:09 p.m.)
Review request for qpid, Andrew Stitcher, Dominic Evans, Gordon Sim, and Rafael
Schloming.
Bugs: proton-895
https://issues.apache.org/jira/browse/proton-895
Repository: qpid-proton-git
Description
-------
This change modifies the way setup.py builds and installs the Proton C library
should it not be present on the system. With this change, setup.py builds the
C library directly, rather than using cmake. The advantages to this:
1) The resultant library is installed in the site-packages directory along with
proton. This allows non-root users properly install the C librarys when doing
a virtualenv or --user install.
2) pip can be used to install/remove the entire proton stack
3) only builds the C library - not the whole proton build
4) no longer requires cmake, which is not part of a typical python environment
Diffs (updated)
-----
proton-c/bindings/python/setup.py 09fa76a
proton-c/bindings/python/setuputils/misc.py 8978371
Diff: https://reviews.apache.org/r/34809/diff/
Testing
-------
All python unit tests pass when run against the bindings and C library
installed with this patch.
Thanks,
Kenneth Giusti
