----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35252/#review87222 -----------------------------------------------------------
proton-c/src/messenger/messenger.c <https://reviews.apache.org/r/35252/#comment139541> Move this platform specific stuff to platform.c. Specifically, create a generic pn_i_getpid() in platform.c and move all the windows/linux conditional logic there. Then have this method use that generic call - no need for conditionals. proton-c/src/messenger/messenger.c <https://reviews.apache.org/r/35252/#comment139542> might as well slap the whole body of logic in here, IMHO. - Kenneth Giusti On June 9, 2015, 4:35 p.m., Flavio Percoco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35252/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 4:35 p.m.) > > > Review request for qpid, Alan Conway, Chug Rolke, Gordon Sim, and Rafael > Schloming. > > > Repository: qpid-proton-git > > > Description > ------- > > Instead of relying on libuuid for uuid generation, let proton-c have a > built-in uuid4 generator to do this job. > > > Diffs > ----- > > proton-c/CMakeLists.txt b534e86 > proton-c/bindings/python/setup.py 79168d2 > proton-c/src/messenger/messenger.c f226f7b > proton-c/src/platform.h 6962493 > proton-c/src/platform.c 8f8ac5f > > Diff: https://reviews.apache.org/r/35252/diff/ > > > Testing > ------- > > > Thanks, > > Flavio Percoco > >
