> On June 11, 2015, 6:34 a.m., Flavio Percoco wrote: > > If the name generation is going to be removed, I really recommend not > > breaking backwards compatibility. We can start letting the users know this > > is going to be removed and then remove it completely in 1 (or 2) releases.
+1 don't break backwards compat. IMO don't break it at all - if the user doesn't care about this name then there's no reason why they should have to specify it. If they do, then they can set it as they wish. Plus this is all an obscure corner of an API that will probably soon be replaced by the event-based APIs. Breaking compat will just annoy people to no purpose. - Alan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35252/#review87528 ----------------------------------------------------------- On June 9, 2015, 5:37 p.m., Flavio Percoco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35252/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 5:37 p.m.) > > > Review request for qpid, Alan Conway, Chug Rolke, Gordon Sim, and Rafael > Schloming. > > > Repository: qpid-proton-git > > > Description > ------- > > Instead of relying on libuuid for uuid generation, let proton-c have a > built-in uuid4 generator to do this job. > > > Diffs > ----- > > proton-c/CMakeLists.txt b534e86 > proton-c/bindings/python/setup.py 79168d2 > proton-c/src/messenger/messenger.c f226f7b > proton-c/src/platform.h 6962493 > proton-c/src/platform.c 8f8ac5f > > Diff: https://reviews.apache.org/r/35252/diff/ > > > Testing > ------- > > > Thanks, > > Flavio Percoco > >
