----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36315/#review90912 -----------------------------------------------------------
Ship it! I think this is probably the correct semantic for the SSL hostname, if you have multiple ways of setting it. However my original intention was to deprecate the separate SSL way to set the peer hostname (I should probably add a deprecated note to the doctext). Is there actually a case where you would ever want the SASL peer hostname ever to be different from the SSL hostname? I can't think of any reason myself. proton-c/src/transport/transport.c (line 665) <https://reviews.apache.org/r/36315/#comment144082> Nit: I'm guessing there are tab characters here - Andrew Stitcher On July 8, 2015, 4:08 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36315/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 4:08 p.m.) > > > Review request for qpid and Andrew Stitcher. > > > Bugs: proton-939 > https://issues.apache.org/jira/browse/proton-939 > > > Repository: qpid-proton-git > > > Description > ------- > > Prevents the connection's hostname setting overriding one set via > pn_ssl_set_peer_hostname > > > Diffs > ----- > > proton-c/include/proton/ssl.h b250e6a > proton-c/src/transport/transport.c e5e8276 > tests/python/proton_tests/ssl.py f3c7f1f > > Diff: https://reviews.apache.org/r/36315/diff/ > > > Testing > ------- > > new unit tests added > > > Thanks, > > Kenneth Giusti > >
