----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36315/#review90947 -----------------------------------------------------------
proton-c/src/transport/transport.c (line 661) <https://reviews.apache.org/r/36315/#comment144108> hmm, you added a string size check, surely if it's needed here (I'm not sure it is) then it is also needed above in the SASL section. And in that case it might be better to bracket boith in the test. However I think that setting a null string to another null string isn't an issue (or at least it wasn't in my testing) - Andrew Stitcher On July 8, 2015, 4:08 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36315/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 4:08 p.m.) > > > Review request for qpid and Andrew Stitcher. > > > Bugs: proton-939 > https://issues.apache.org/jira/browse/proton-939 > > > Repository: qpid-proton-git > > > Description > ------- > > Prevents the connection's hostname setting overriding one set via > pn_ssl_set_peer_hostname > > > Diffs > ----- > > proton-c/include/proton/ssl.h b250e6a > proton-c/src/transport/transport.c e5e8276 > tests/python/proton_tests/ssl.py f3c7f1f > > Diff: https://reviews.apache.org/r/36315/diff/ > > > Testing > ------- > > new unit tests added > > > Thanks, > > Kenneth Giusti > >
