[ 
https://issues.apache.org/jira/browse/QPID-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653332#comment-14653332
 ] 

Alex Rudyy commented on QPID-3521:
----------------------------------

Keith,
I raised JIRA [QPID-6677|https://issues.apache.org/jira/browse/QPID-6677] to 
address your comment #1.
Regarding comment #2: The test does not only test stop functionality. The 
primary purpose of it is to make sure that pre-dispatch queue with messages is 
drained regardless whether dispatcher stopped or not.
I could not figure out the better way to make sure that messages are prefetched 
and have not get into the consumers queues. For that purpose, I stopped the 
queue from a dispatcher thread.
Regarding comment #3: I fill made the change to address pointed issue.
Regarding comment #4: I will implement the fix. It seems we got the separate 
JIRA about the issue 
[QPID-3520|https://issues.apache.org/jira/browse/QPID-3520]. It make sense to 
do as part of JIRA [QPID-3520|https://issues.apache.org/jira/browse/QPID-3520].

> failover process for the 0-8 client does not clear the pre-dispatch queue
> -------------------------------------------------------------------------
>
>                 Key: QPID-3521
>                 URL: https://issues.apache.org/jira/browse/QPID-3521
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>            Reporter: Robbie Gemmell
>            Assignee: Keith Wall
>              Labels: failover
>         Attachments: clear-dispatch-queue-on-failover.diff
>
>
> failover process for the 0-8 client does not clear the pre-dispatch queue, 
> only the consumer receive queue.
> This is currently masked by an issue with the rollbackMark. The changes made 
> in QPID-3546 to fix the 0-10 client path need to be applied to the 0-8/9/9-1 
> client path when this issue is resolved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to