[ https://issues.apache.org/jira/browse/QPID-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659808#comment-14659808 ]
Keith Wall commented on QPID-3521: ---------------------------------- A couple of comments: # What is the rationale behind taking of AllConnectionAndSessionLocks for failover on the 0-10 and 0-8..0-91 paths? I think it would be useful to write this down (on this Jira). # We have a plethora on 'clean' dispatch queue type methods building up on AMQSession - some exclusively for 0-10 and some for 0-8..0-91 and these contribute to making the code hard to fathom. I wonder if this methods should be pushed down to the respective subclasses? (Sorting this out properly is beyond the scope of the Jira). > failover process for the 0-8 client does not clear the pre-dispatch queue > ------------------------------------------------------------------------- > > Key: QPID-3521 > URL: https://issues.apache.org/jira/browse/QPID-3521 > Project: Qpid > Issue Type: Bug > Components: Java Client > Reporter: Robbie Gemmell > Assignee: Alex Rudyy > Labels: failover > Attachments: clear-dispatch-queue-on-failover.diff > > > failover process for the 0-8 client does not clear the pre-dispatch queue, > only the consumer receive queue. > This is currently masked by an issue with the rollbackMark. The changes made > in QPID-3546 to fix the 0-10 client path need to be applied to the 0-8/9/9-1 > client path when this issue is resolved. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org