[
https://issues.apache.org/jira/browse/DISPATCH-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037823#comment-15037823
]
ASF GitHub Bot commented on DISPATCH-190:
-----------------------------------------
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/38#discussion_r46554871
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -633,7 +633,13 @@
"default": "both",
"description": "['in', 'out', 'both', 'no'] in: Strip
the dispatch router specific annotations only on ingress; out: Strip the
dispatch router specific annotations only on egress; both: Strip the dispatch
router specific annotations on both ingress and egress; no - do not strip
dispatch router specific annotations",
"create": true
- }
+ },
+ "protocolFamily": {
--- End diff --
Rather than duplicate this entry for both listener and connector, you could
put this in the "addrPort" annotation. Like addr and port, protocolFamily is
common to both entity types.
You have a default of IPv4 in the connector. That is inconsistent with the
document string.
> Expose the Protocol Family for the configuration of listeners and connectors
> ----------------------------------------------------------------------------
>
> Key: DISPATCH-190
> URL: https://issues.apache.org/jira/browse/DISPATCH-190
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
> Reporter: Ted Ross
> Assignee: Ganesh Murthy
> Fix For: 0.6
>
>
> Add a protocol-family attribute to listeners and connectors. If configured,
> use the specified value in the creation of the underlying socket. If left to
> default, use the current behavior of determining the protocol family from the
> address.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
