On Jan. 25, 2016, 2:42 p.m., Cliff Jansen wrote: > > Since the interrupt is now essentially a special method on the reactor, > > EventInjector as a separate, user-visiable class doesn't make as much sense > > in my view. I'd be inclined to try and merge it into Container. > > Alan Conway wrote: > I am confused by the event injector. Why is it injecting a proton event? > What event type does it have? I would have expected to simply inject a > callable object that will be executed in the correct context, or at least an > event with a specific APPLICATION_EVENT type to which I could attach my own > code or data. Why would I disguise an application event as if it came from > proton?
It is indeed application specific events types that are injected (and they can have their own context). They aren't intended to be 'disguised' in anyway, but they have to confrm to the collectors notion of what an event is. The choice of events as opposed to callable objects was an attempt at simplicity through more uniformity. - Gordon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42647/#review116070 ----------------------------------------------------------- On Jan. 22, 2016, 8:11 a.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42647/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 8:11 a.m.) > > > Review request for qpid, Alan Conway, Andrew Stitcher, Gordon Sim, and Justin > Ross. > > > Bugs: PROTON-1071 > https://issues.apache.org/jira/browse/PROTON-1071 > > > Repository: qpid-proton-git > > > Description > ------- > > Wrote new thread safe primitives for reactor and selector for Windows and > adapted the existing posix self-pipe mechanism to the changed API. > > Reworked the Python EventInjector to use these primitives via special swig > functions. > > Updated the io.h documentation to reflect the more conservative thread > guarantee. > > > Diffs > ----- > > examples/python/db_recv.py 8c79049 > examples/python/db_send.py c07dcc0 > proton-c/bindings/python/cproton.i 734069f > proton-c/bindings/python/proton/reactor.py 195ff28 > proton-c/include/proton/event.h 16d2bda > proton-c/include/proton/io.h 19dfe53 > proton-c/include/proton/reactor.h e91b169 > proton-c/include/proton/selector.h c942393 > proton-c/src/events/event.c 5ad718e > proton-c/src/posix/selector.c 7f72c84 > proton-c/src/reactor/reactor.c 7ea279b > proton-c/src/windows/iocp.h 0e052e5 > proton-c/src/windows/iocp.c 404dd36 > proton-c/src/windows/selector.c f139aec > tests/python/proton_tests/reactor.py 6ee107d > > Diff: https://reviews.apache.org/r/42647/diff/ > > > Testing > ------- > > rhel7, windows8 > > > Thanks, > > Cliff Jansen > >
