[
https://issues.apache.org/jira/browse/QPID-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147391#comment-15147391
]
Lorenz Quack commented on QPID-7028:
------------------------------------
* I don't like that the DEFAULT_LOGIN_URL lives in
UsernamePasswordInteractiveLogin whereas DEFAULT_LOGOUT_URL lives in
HttpManagement
* There are a couple of typos in TODO comment in
UsernamePasswordInteractiveLogin:
** When we refactor web management and adopt -a- web fragments, move
login.html and -login.html- logout.html
* In OAuth2InteractiveAuthenticator why do you convert the logoutURI to a URL
only to then turn it into a string? could you not turn the URI into a string
directly? In that case you would not have to deal with a MalformedURLException.
And IF you want to ensure the URI has a valid syntax I think that it should
rather be handled in onValidate/validateChange on the AuthenticationProvider
* in logout.html the link to the login.html is a relative link. Are we happy
with that or should it rather be a absolute path "/index.html"?
* in logout.html why do you use the onClick handler for what seems to be a
simple link? what is wrong with <a href>?
> [Java Broker] Add OAuth2 AuthenticationProvider
> -----------------------------------------------
>
> Key: QPID-7028
> URL: https://issues.apache.org/jira/browse/QPID-7028
> Project: Qpid
> Issue Type: New Feature
> Components: Java Broker
> Reporter: Lorenz Quack
> Attachments: 0001-OAuth2.patch,
> 0001-QPID-7028-Java-Broker-Improve-OAuth2.patch,
> 0001-QPID-7028-Java-Broker-OAuth2-improvements.patch,
> 0001-QPID-7028-OAuth2-Identity-Resolver-implementation-ca.patch,
> 0001-WIP-OAuth2-working-initial-refactor-complete.patch
>
>
> We want to provide the ability to login to the web management console with
> OAuth2. It should be possible to use different OAuth2 backend (e.g., Google,
> CloudFoundry)
> Therefore it needs
> * pluggable way of setting the various parameters on the OAuth2 requests
> * pluggable way of getting the various parameters from the OAuth2 responses
> (e.g., access grant, access token, refresh token, and expiry time, and user
> id)
> * those pluggable parts should have configurable addresses
> * configurable trust store for the OAuth2 servers
> * the client secret should be marked as "secure"
> * It should use (if available) a check_token or check_id service to get a
> user id to use for ACL / logging purposes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
