[
https://issues.apache.org/jira/browse/PROTON-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314756#comment-15314756
]
Andrew Stitcher commented on PROTON-1226:
-----------------------------------------
I can't see an issue in the code you've provided as we've already decided that
once options including a handler are applied they can't be changed. So if we
apply the handler at the first opportunity we have for a given link then it
can't be changed after that anyway.
It also looks to me like this is a sufficiently bad bug that we should apply
this fix to 0.13 too (assuming it makes the test work again).
> Handler not set on inbound connection
> -------------------------------------
>
> Key: PROTON-1226
> URL: https://issues.apache.org/jira/browse/PROTON-1226
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
> Affects Versions: 0.13.0, 0.14.0
> Reporter: Cliff Jansen
> Assignee: Cliff Jansen
> Fix For: 0.14.0
>
>
> Historically, the handler was always specified before the connection was
> created so that the PN_CONNECTION_INIT could go to the correct handler,
> whereas the rest of the connection options could only be applied later, after
> creation.
> For inbound connections, the handler was set on the listener
> (pn_reactor_acceptor()) and the reactor set it for the accepted connections.
> History has changed. Nobody processes PN_CONNECTION_INIT except the global
> handler, so deferred setting of the handler is probably OK, allowing the
> handler to be set at the same time as the other non-transport options.
> Alternatively, the caller of on_accept() must separately apply the handler
> (which might change per connection on a listener) to make the new
> listen_handler interface work as intended.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
