[
https://issues.apache.org/jira/browse/PROTON-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314815#comment-15314815
]
Cliff Jansen commented on PROTON-1226:
--------------------------------------
The CI test works fine with above fix.
On further investigation, option 1 doesn't even make sense in the case of
connection_engine, which does not use a pn_handler_t intermediary and doesn't
want apply() to set any C reactor context on the connection.
I originally thought option 1 might be the better option for consistency
between connection_engine and container, but that is clearly not the case.
For clarity, this fix correctly honours the connection_option handler for the
connection as a whole. It does not address any outstanding issues related to
providing separate handlers for links or sessions.
> Handler not set on inbound connection
> -------------------------------------
>
> Key: PROTON-1226
> URL: https://issues.apache.org/jira/browse/PROTON-1226
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
> Affects Versions: 0.13.0, 0.14.0
> Reporter: Cliff Jansen
> Assignee: Cliff Jansen
> Fix For: 0.14.0
>
>
> Historically, the handler was always specified before the connection was
> created so that the PN_CONNECTION_INIT could go to the correct handler,
> whereas the rest of the connection options could only be applied later, after
> creation.
> For inbound connections, the handler was set on the listener
> (pn_reactor_acceptor()) and the reactor set it for the accepted connections.
> History has changed. Nobody processes PN_CONNECTION_INIT except the global
> handler, so deferred setting of the handler is probably OK, allowing the
> handler to be set at the same time as the other non-transport options.
> Alternatively, the caller of on_accept() must separately apply the handler
> (which might change per connection on a listener) to make the new
> listen_handler interface work as intended.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
