[
https://issues.apache.org/jira/browse/QPID-7247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367455#comment-15367455
]
Lorenz Quack commented on QPID-7247:
------------------------------------
Changes look correct to me. Some minor questions/comments:
* I am surprised that when requesting with wild cards the results are all
lumped together. Is the association then later performed by looking up the
associatedObject Id?
* In {{PreferencesTest}} you started to use guava {{Sets.newHashSet()}}. What
is the advantage of that instead of {{Collections.singleton()}} what we seem to
use in most other cases?
* formatting does not comply with our style guide (e.g., space after {{if}},
{{while}} and {{for}}, binary logic operators at beginning of new line)
* while amusing I think I would find {{RequestInfo#hasWildcard}} more
descriptive than {{RequestInfo#isWild}}
It took me a while to figure out that one of the largest changes in this patch
(refactoring of filtering in {{RestServlet#getObject}}) has very little to do
with the JIRA.
> Implement preferences model and REST API
> ----------------------------------------
>
> Key: QPID-7247
> URL: https://issues.apache.org/jira/browse/QPID-7247
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: qpid-java-6.1
>
>
> Implement the preferences model and the REST API described by:
> https://cwiki.apache.org/confluence/display/qpid/Preference+Store
> After this work it will be possible to add/update/remove preference from the
> REST API, but there will be no persistence. At this stage all preferences
> will be available to all users. There will be no security in preferences
> layer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
