[ 
https://issues.apache.org/jira/browse/QPID-7247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369451#comment-15369451
 ] 

Rob Godfrey commented on QPID-7247:
-----------------------------------

PreferencesTest was failing with
{noformat}
testReplaceByTypeAndName(org.apache.qpid.server.model.testmodels.singleton.PreferencesTest)
  Time elapsed: 0.008 sec  <<< FAILURE!
junit.framework.AssertionFailedError: Unexpected number of preferences 
expected:<3> but was:<2>
        at junit.framework.Assert.fail(Assert.java:57)
        at junit.framework.Assert.failNotEquals(Assert.java:329)
        at junit.framework.Assert.assertEquals(Assert.java:78)
        at junit.framework.Assert.assertEquals(Assert.java:234)
        at junit.framework.TestCase.assertEquals(TestCase.java:401)
        at 
org.apache.qpid.server.model.testmodels.singleton.PreferencesTest$13.run(PreferencesTest.java:694)
        at 
org.apache.qpid.server.model.testmodels.singleton.PreferencesTest$13.run(PreferencesTest.java:681)
        at java.security.AccessController.doPrivileged(Native Method)
        at javax.security.auth.Subject.doAs(Subject.java:360)
        at 
org.apache.qpid.server.model.testmodels.singleton.PreferencesTest.testReplaceByTypeAndName(PreferencesTest.java:680)
{noformat}

due to the fact that the comparator was treating two preferences with the same 
name but different types as equal (and thus only allowing one in the Set).  I 
have changed the comparator to also consider the type and the id.

> Implement preferences model and REST API
> ----------------------------------------
>
>                 Key: QPID-7247
>                 URL: https://issues.apache.org/jira/browse/QPID-7247
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>             Fix For: qpid-java-6.1
>
>
> Implement the preferences model and the REST API described by:
> https://cwiki.apache.org/confluence/display/qpid/Preference+Store
> After this work it will be possible to add/update/remove preference from the 
> REST API, but there will be no persistence.  At this stage all preferences 
> will be available to all users.   There will be no security in preferences 
> layer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to