[
https://issues.apache.org/jira/browse/QPID-7359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432813#comment-15432813
]
Lorenz Quack commented on QPID-7359:
------------------------------------
Majority looks good.
ConfigurationExtractor
* The handling of encrypted attributes seems odd. Why do we distinguish the
case where an encrypter is present? wouldn't
{{attributeDefinition.getValue(object)}} always do the right thing?
* Similarly, you try to avoid exporting UUIDs when they appear in references
(which makes sense) so isn't saving the {{obj.getName()}} always the right
thing to do? Why do we need the if/else?
* Map<> containing COs should be handled specially (i.e. RedirectingVHN) to
avoid exporting UUIDs
* strange mix of iterator and for-loop in multi-parent handling
* VH#extractConfig is only allowed over https. should this depend on
includeSecureAttributes? (btw, Broker#extractConfig has no such restriction.
see my comment on QPID-7380)
LegacyAccessControlAdapter
* VH#extractConfig is not mapped to a legacy operation so would always be
allowed (see below)
Sidenote:
* LegacyAccessControlAdapter#authoriseMethod returns Result.ALLOWED by
default. should it not be DEFER or null or error?
> Improve ability to clone a broker's configuration
> -------------------------------------------------
>
> Key: QPID-7359
> URL: https://issues.apache.org/jira/browse/QPID-7359
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
>
> As a user, I may wish to clone all or part of Broker's configuration, so I
> can source control configuration and create many Brokers with identical
> configuration.
> We already have a REST operation to extract the configuration, but when
> invoked from the Broker it extracts the entire object tree. The user needs
> the ability to extract Broker and Virtualhost configuration separately.
> The existing {{extractInitialConfig}} RestServlet option should be removed
> and in its place operations added at the Broker and Virtualhost level. The
> generated extract should stop at the discontinuities within the model.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
