[
https://issues.apache.org/jira/browse/QPID-7359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438904#comment-15438904
]
Lorenz Quack commented on QPID-7359:
------------------------------------
* In {{ConfigurationExtractor#getTypeParameterClass}} the parameter
{{paramIndex}} is unused which seems like a bug.
* It seems like your code assumes that the order of iterating over
values.entrySet() is going to be the same as iterating over ((Map<?,?>)
attr.getValue()).entrySet(). I don't think that is a valid assumption.
* It might be time to break up {{ConfigurationExtractor#extractConfig}}. There
seem to be three distinct blacks (1 for-loop and 2 if-blocks) where the
for-loop might be broken up further.
> Improve ability to clone a broker's configuration
> -------------------------------------------------
>
> Key: QPID-7359
> URL: https://issues.apache.org/jira/browse/QPID-7359
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Rob Godfrey
>
> As a user, I may wish to clone all or part of Broker's configuration, so I
> can source control configuration and create many Brokers with identical
> configuration.
> We already have a REST operation to extract the configuration, but when
> invoked from the Broker it extracts the entire object tree. The user needs
> the ability to extract Broker and Virtualhost configuration separately.
> The existing {{extractInitialConfig}} RestServlet option should be removed
> and in its place operations added at the Broker and Virtualhost level. The
> generated extract should stop at the discontinuities within the model.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
