[
https://issues.apache.org/jira/browse/QPID-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439158#comment-15439158
]
Alex Rudyy commented on QPID-7381:
----------------------------------
Rob
I reviewed the changes. Here are my review comments:
1) AbstractQueue.tryDeliverStraightThrough
Why only consumer with priority 0 is allowed to attempt delivery on straight
through path?
Would it be better to allow an attempt for a consumer with highest priority too?
Similar to AbstractQueu.attemptDelivery:
{code}
(sub.getPriority() == 0 || noHigherPriorityWithCredit(sub))
{code}
2) SendingLinkEndpoint
Do we really have AMQShortString on AMQP 1.0 implementation?
I think that below should not include AMQShortString check
{code}
else if(value instanceof String || value instanceof AMQShortString)
{code}
3) ConsumerPriorityTest
it is unnessesary to start producing only connection in setUp
4) I think we need to document priority feature and how to use it from client
on both 0.10 and 0.9 paths
5) I am wondering whether Qpid JMS API should allow alternative way to specify
a consumer priority over special method Session.createConsumer(Destination,
priority) in addition to specifying priority via destination url? Parameter
x-priority in BURL looks unnatural to me.
> [Java Broker] Support consumer priorities
> -----------------------------------------
>
> Key: QPID-7381
> URL: https://issues.apache.org/jira/browse/QPID-7381
> Project: Qpid
> Issue Type: New Feature
> Components: Java Broker
> Reporter: Rob Godfrey
> Fix For: qpid-java-6.1
>
>
> Support the concept of consumer priorities. A consumer of a lower priority
> should only receive a message if there exists no consumer on the queue of a
> higher priority which has credit and would accept the message if offered it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
