[
https://issues.apache.org/jira/browse/QPID-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467617#comment-15467617
]
Alex Rudyy commented on QPID-7381:
----------------------------------
Rob,
Here are my review comments for changes made under revision
[r1758900|https://svn.apache.org/r1758900]:
# The existing implementation of SendingLinkEndpoint overrides the priority
value specified as part of properties in attach with Integer.MAX_VALUE
{code}
if (_priority < Integer.MAX_VALUE)
{
_priority = Integer.MAX_VALUE;
}
{code}
# Additionally, I am wondering whether SendingLinkEndpoint#_priority should be
initialized to Integer.MAX_VALUE. When attach properties are missing the
priority will be set to 0. I think that changing _priority field type to
java.lang.Integer would be more correct and inline with other protocol
implementations.
Documentation looks good to me.
> [Java Broker] Support consumer priorities
> -----------------------------------------
>
> Key: QPID-7381
> URL: https://issues.apache.org/jira/browse/QPID-7381
> Project: Qpid
> Issue Type: New Feature
> Components: Java Broker
> Reporter: Rob Godfrey
> Fix For: qpid-java-6.1
>
>
> Support the concept of consumer priorities. A consumer of a lower priority
> should only receive a message if there exists no consumer on the queue of a
> higher priority which has credit and would accept the message if offered it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
