Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/101#discussion_r80100058
  
    --- Diff: include/qpid/dispatch/iterator.h ---
    @@ -180,6 +180,8 @@ void qd_address_iterator_set_phase(qd_field_iterator_t 
*iter, char phase);
      */
     void qd_address_iterator_override_prefix(qd_field_iterator_t *iter, char 
prefix);
     
    +void qd_address_iterator_set_length(qd_field_iterator_t *iter, int length);
    --- End diff --
    
    Two things:  This function should be a "qd_field_iterator..." function, not 
a "qd_address_iterator..." function.  There is nothing address-specific about 
this operation.
    
    Also, it might be clearer to call this "qd_field_iterator_trim" with an 
argument called "new_length".  This suggests that the length can only be 
reduced.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to