[
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645370#comment-15645370
]
ASF GitHub Bot commented on PROTON-1330:
----------------------------------------
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/85
A couple of comments:
* It seems entirely arbitrary (to me anyway) to move generating encoding.h
and protocol.h from the C build process to generating them when producing the C
part of the python install. We know that we have python available at the time
of build the C code (well duh!) so we could keep on generating at C build time
when we do the python install.
This seems to me to minimise the divergence between the packaged C source
for the python package and the real C source tree.
* Given the c code built by the python install is somewhat selective anyway
- it makes sense (again to me anyway) only to package C source which is
actually used in the library used by the python installation.
> Include the C sources in the python source distribution
> -------------------------------------------------------
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: 0.15.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by
> apache infrastructure maintainers. This will lead to failures when
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the
> necessary proton-c source files for inclusion in the python bindings package.
> Instead of fetching the necessary sources from apache, setup.py can simply
> build and install the proton library using the bundled sources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
