[
https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664699#comment-15664699
]
ASF GitHub Bot commented on PROTON-1330:
----------------------------------------
Github user kgiusti commented on the issue:
https://github.com/apache/qpid-proton/pull/85
re: encoding.h and protocol.h:
I didn't want to duplicate the generation of these files in the python
CMakeLists.txt but as it stands now these files are generated during the build
phase - not the cmake configuration pass. I can either 1) require the C
compilation is done prior to building the Python source distribution or 2) move
the file generation to the cmake configuration phase.
re: packaging C source
I'm not entirely sure I understand - are you suggesting some of the C files
are not needed by the Python bindings? I assume I can hunt around for these
files, but isn't all Proton/C functionality accessible via the python bindings,
since the binding is used by the python unit tests?
> Include the C sources in the python source distribution
> -------------------------------------------------------
>
> Key: PROTON-1330
> URL: https://issues.apache.org/jira/browse/PROTON-1330
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: 0.15.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Blocker
> Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the
> apache dist url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by
> apache infrastructure maintainers. This will lead to failures when
> installing python via setup.py (as is done via pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the
> necessary proton-c source files for inclusion in the python bindings package.
> Instead of fetching the necessary sources from apache, setup.py can simply
> build and install the proton library using the bundled sources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
