Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/125#discussion_r92235068
  
    --- Diff: src/router_core/connections.c ---
    @@ -107,6 +130,61 @@ void qdr_connection_set_context(qdr_connection_t 
*conn, void *context)
             conn->user_context = context;
     }
     
    +qdr_connection_info_t *qdr_connection_info(bool             is_encrypted,
    +                                           bool             
is_authenticated,
    +                                           bool             opened,
    +                                           char            
*sasl_mechanisms,
    +                                           const char      *dir,
    --- End diff --
    
    There is an enumerated type for direction.  You should use this rather than 
passing strings around.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to