Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/125#discussion_r92235417
  
    --- Diff: src/router_core/router_core_private.h ---
    @@ -439,10 +439,28 @@ typedef struct qdr_connection_work_t {
     ALLOC_DECLARE(qdr_connection_work_t);
     DEQ_DECLARE(qdr_connection_work_t, qdr_connection_work_list_t);
     
    +struct qdr_connection_info_t {
    +    const  char                *container;
    +    char                       *sasl_mechanisms;
    +    char                       *host;
    +    bool                        is_encrypted;
    +    char                       *ssl_proto;
    +    char                       *ssl_cipher;
    +    char                       *user;
    +    bool                        is_authenticated;
    +    bool                        opened;
    +    const char                 *dir;
    --- End diff --
    
    I think dir and role should use the enumerated types rather than arbitrary 
strings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to