[
https://issues.apache.org/jira/browse/PROTON-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804028#comment-15804028
]
Adel Boutros edited comment on PROTON-1383 at 1/6/17 8:46 AM:
--------------------------------------------------------------
Hello [~astitcher],
I cannot say I am a very expert C++ developer because I don't consider I have
the needed experience yet. However, it seems logical for me to add an include
wherever it is actually needed.
In *link.hpp*, there is a reference to *_error_condition_* so for me it makes
sence to have there. This way who ever includes link.hpp have all the needed
class dependencies as well.
{code:java}//link.hpp line 55
PN_CPP_EXTERN void close(const error_condition&);
{code}
*message.cpp* is just an example. If I don't include it in *link.hpp*, I will
have to add it to 10 files to get the compilation to work (Wherever *link.hpp*
is included, I have to include *error_condition.hpp* as well)
>From what I have seen, Solaris is very picky about missing transitive includes
>and is always complaining about them. Whenever you use a class directly, the
>corresponding include should be added.
What do you think?
was (Author: adelbout...@live.com):
Hello [~astitcher],
I cannot say I am a very expert C++ developer because I don't consider I have
the needed experience yet. However, it seems logical for me to add an include
where it is actually needed.
In *link.hpp*, there is a reference to *_error_condition_* so for me it makes
sence to have there. This way who ever includes link.hpp have all the needed
class dependencies as well.
{code:java}//link.hpp line 55
PN_CPP_EXTERN void close(const error_condition&);
{code}
*message.cpp* is just an example. If I don't include it in *link.hpp*, I will
have to add it to 10 files to get the compilation to work (Wherever *link.hpp*
is included, I have to include *error_condition.hpp* as well)
>From what I have seen, Solaris is very picky about missing transitive includes
>and is always complaining about them. Whenever you use a class directly, the
>corresponding include should be added.
What do you think?
> Add missing includes to fix Solaris compilation
> -----------------------------------------------
>
> Key: PROTON-1383
> URL: https://issues.apache.org/jira/browse/PROTON-1383
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.16.0
> Reporter: Adel Boutros
> Labels: patch
> Fix For: 0.17.0
>
> Attachments: 0002-add-missing-includes.patch
>
>
> All details available here:
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
