[
https://issues.apache.org/jira/browse/PROTON-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830053#comment-15830053
]
Andrew Stitcher edited comment on PROTON-1383 at 1/19/17 2:49 PM:
------------------------------------------------------------------
[[email protected]] Thanks for this work. I'm now somewhat unsure about the
correct fix. It seems that the Solaris compiler (unlike all others I've used)
needs a class definition for return types to generate virtual table members.
However I'm confused that it is only complaining about link::error() and not
session::error() or connection::error()., because those all inherit the virtual
function error from endpoint, and don't define it either.
I'm going to think about this a bit more, but I'm leaning towards actually
including error_condition in a header file now - actually endpoint.hpp. Looking
at the changes to the examples you made, I'm thinking more that it is odd to
have to include header files defining types that you don't use at all. My
argument before doesn't really work here - above I assumed that you were using
the type, but maybe didn't know it. Actually with this change you have to
include a header for a type you don't use at all.
Sorry, for the time spent on this, but thanks for taking this journey with me!
It would be so much easier of I could compile with this compiler myself!
was (Author: astitcher):
[[email protected]] Thanks for this work. I'm now somewhat unsure about the
correct fix. It seems that the Solaris compiler (unlike all others I've used)
needs a class definition for return types to generate virtual table members.
However I'm confused that it is only complaining about link::error() and not
session::error() or connection::error()., because those all inherit the virtual
function error from endpoint, and don't define it either.
I'm going to think about this a bit more, but I'm leaning towards actually
includeing error_condition in a header file now - actually endpoint.hpp.
Looking at the changes to the examples you made, I'm thinking more that it is
odd to have to include header files defining types that you don't use at all.
My argument before doesn't really work here - above I assumed that you were
using the type, but maybe didn't know it. Actually with this change you have to
include a header for a type you don't use at all.
Sorry, for the time spent on this, but thanks for taking this journey with me!
It would be so much easier of I could compile with this compiler myself!
> Add missing includes to fix Solaris compilation
> -----------------------------------------------
>
> Key: PROTON-1383
> URL: https://issues.apache.org/jira/browse/PROTON-1383
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.16.0
> Reporter: Adel Boutros
> Assignee: Andrew Stitcher
> Labels: patch
> Fix For: 0.17.0
>
> Attachments: 0001-Fix-missing-includes-for-Solaris.patch,
> 0002-add-missing-includes.patch
>
>
> All details available here:
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
