[ 
https://issues.apache.org/jira/browse/PROTON-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812242#comment-15812242
 ] 

Alan Conway commented on PROTON-1382:
-------------------------------------

I'm fine with this patch. I made the change in the interests of general 
struct-packing best practice. In this case the use of bit fields makes no 
difference, moving the bools to the end is sufficient as the struct is going to 
be pointer aligned in any case.


> Remove bit fields initialization for bool fields
> ------------------------------------------------
>
>                 Key: PROTON-1382
>                 URL: https://issues.apache.org/jira/browse/PROTON-1382
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.16.0
>            Reporter: Adel Boutros
>              Labels: patch
>             Fix For: 0.17.0
>
>         Attachments: 
> 0001-Remove-bit-fields-initialization-for-bool-fields.patch
>
>
> All details available here: 
> http://qpid.2158936.n2.nabble.com/Proton-0-16-0-Solaris-Unit-tests-hanging-when-destroying-connection-driver-td7657231.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to