Github user ssorj commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/93#discussion_r95426083
--- Diff: proton-c/bindings/python/proton/__init__.py ---
@@ -2581,6 +2581,9 @@ def close(self):
"""
self._update_cond()
pn_connection_close(self._impl)
+ if hasattr(self, '_session_policy'):
--- End diff --
Out of curiosity, why isn't _session_policy a stable attribute of the
object? That is, could we simply assign None here? I would prefer that a bit
if it makes no difference. This likely predates your change, but I usually try
to avoid having to test for the presence of attributes in Python objects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
