Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/93#discussion_r95596711
--- Diff: proton-c/bindings/python/proton/utils.py ---
@@ -132,10 +132,12 @@ def __init__(self, connection, receiver, fetcher,
credit=1):
raise LinkException("Failed to open receiver %s, source does
not match" % self.link.name)
if credit: receiver.flow(credit)
self.fetcher = fetcher
+ self.container = connection.container
def __del__(self):
self.fetcher = None
- self.link.handler = None
+ self.link.handler = None # fails if reactor finalizes first
--- End diff --
+1 the comment should read something like "this would cause a core dump if
the reactor finalized first, but that is impossible because *explain
refcounting tricks here*" It is important to leave some explanation, this is
exactly the sort of thing that someone in future will think "this doesn't seem
necessary" and change it without realizing they are re-introducing a heisenbug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
