[
https://issues.apache.org/jira/browse/QPID-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843079#comment-15843079
]
Alex Rudyy commented on QPID-7609:
----------------------------------
I reviewed changes committed against this JIRA. Here are my review comments and
questions:
* Why property "project.build.sourceEncoding" is set qpid-systests-jms_2.0 and
not in qpid-java-build pom?
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
* In order to avoid duplication of bdb/je dependencies in every systests
module, they can be moved into parent module - qpid-systests-parent.
{code:xml}
<dependency>
<groupId>org.apache.qpid</groupId>
<artifactId>qpid-bdbstore</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.sleepycat</groupId>
<artifactId>je</artifactId>
<version>${bdb-version}</version>
<scope>test</scope>
</dependency>
{code}
The better place for them would be bdb profile, but due to multipe bdb
profiles, having them declared in qpid-systests-parent would be an acceptible
approach
* AmqpManagementFacade
Currently AmqpManagementFacade is coupled with QBTC and requires passing of an
instance into constructor.
IMHO, there is no need for that. Instead, a boolean constructor argument
'userAddressSyntax' can be used to indicate that address-based destination is
required.
* QBTC#appendOptions can be removed. EndToEndTest is the only test using it
* org.apache.qpid.test.utils.QpidJmsClientProvider#getInitialContext
I think this method should throw UnsupportedOperationException in
QpidJmsClientProvider as returning empty Context does not make sense.
#getInitialContext is only used by 3 tests to lookup for queue and topic. We
can replace those invocations with getTestQueue()/getTestTopic() and remove
#getInitialContext from JmsProvider interface
* HeartbeatTest/SSLTest
After introduction of JmsProvider#getConnectionWithOptions(Map) we can remove
usage of connection URL from the tests and call #getConnectionWithOptions(Map)
instead.
* Open connections could be leaked if not explicitly closed when
FailoverBaseCase#getConnection() is called
> JMS 2.0 systests module
> -----------------------
>
> Key: QPID-7609
> URL: https://issues.apache.org/jira/browse/QPID-7609
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: qpid-java-7.0
>
> Attachments:
> 0001-QPID-7609-Java-System-Tests-Add-a-JMS-2.0-systest-mo.patch
>
>
> We need the ability to test JMS 2.0 features end to end against the Java
> Broker. We will have a separate module that will be activated only on the
> 1.0 AMQP test profiles. It will contain tests written in terms of JMS 2.0
> API. AMQP Management will be used to perform any setup.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
