[
https://issues.apache.org/jira/browse/QPID-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843181#comment-15843181
]
Keith Wall commented on QPID-7609:
----------------------------------
I've address a number of your comments in the next commit.
I am leaving these:
* We should be setting project.build.sourceEncoding across the whole project to
get rid of the build warnings, as a separate JIRA.
* the way we do dependencies is just wrong. we should be using
profiles/properties to drive system testing -Dsystest,store=BDB
-Dsystest.protocol=AMQP0-9 -Dsystest,.brokertype=Java etc. Tests should be
annotated to opt themselves in or out of a test run.
* QBTC - this change was largely an delegation extraction refactoring. The API
is horrid as it stands especially for creating connections. I'd like to see
something a JMS provider neutral
{{getConnnectionBuilder().getDefaultConnection().addFailover()}} and the
builder implementation can take care of doing it for the underlying Qpid JMS
impl. I'd prefer not to polish what we have now. I think that would be a
waste,.
> JMS 2.0 systests module
> -----------------------
>
> Key: QPID-7609
> URL: https://issues.apache.org/jira/browse/QPID-7609
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: qpid-java-7.0
>
> Attachments:
> 0001-QPID-7609-Address-some-of-the-review-comments.patch,
> 0001-QPID-7609-Java-System-Tests-Add-a-JMS-2.0-systest-mo.patch
>
>
> We need the ability to test JMS 2.0 features end to end against the Java
> Broker. We will have a separate module that will be activated only on the
> 1.0 AMQP test profiles. It will contain tests written in terms of JMS 2.0
> API. AMQP Management will be used to perform any setup.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
