Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/143#discussion_r103748543
  
    --- Diff: src/router_node.c ---
    @@ -226,9 +227,22 @@ static void AMQP_rx_handler(void* context, qd_link_t 
*link, pn_delivery_t *pnd)
         //        send it.
         //
         msg = qd_message_receive(pnd);
    +
         if (!msg)
             return;
     
    +
    +    char repr[qd_message_repr_len()];
    --- End diff --
    
    This declaration should be inside the if statement.  You are needlessly 
allocating stack space when logging is disabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to