Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/143#discussion_r103749521
  
    --- Diff: include/qpid/dispatch/server.h ---
    @@ -451,6 +452,28 @@ typedef struct qd_server_config_t {
          * connection will be automatically closed.
          */
         int idle_timeout_seconds;
    +
    +    /**
    +     *  Holds comma separated list that indicates which components of the 
message should be logged.
    +     *  Defaults to 'none' (log nothing). If you want all properties and 
application properties of the message logged use 'all'.
    +     *  Specific components of the message can be logged by indicating the 
components via a comma separated list.
    +     *  The components are
    +     *  message-id
    +     *   user-id
    +     *   to
    +     *   subject
    +     *   reply-to
    +     *   correlation-id
    +     *   content-type
    +     *   content-encoding
    +     *   absolute-expiry-time
    +     *   creation-time
    +     *   group-id
    +     *   group-sequence
    +     *   reply-to-group-id
    +     *   app-properties.
    +     */
    +    char *log_message;
    --- End diff --
    
    I would recommend storing this in its bit-mask form here.  Then it only 
needs to be parsed once at configuration time.  This also allows you to isolate 
the string definitions and the conversion functions to a single .h/.c module.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to