[ 
https://issues.apache.org/jira/browse/PROTON-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975124#comment-15975124
 ] 

ASF GitHub Bot commented on PROTON-1463:
----------------------------------------

GitHub user mastash3ff opened a pull request:

    https://github.com/apache/qpid-proton/pull/103

    PROTON-1463 GO-Bindings Added AMQP Address Method

    Original examples used url.Path variable to return the amqp address.  The 
address returned added an unnecessary prepended slash character.  Added a 
amqp.Address() method to filter the slash character out.  
    
    Original problem running example:  ./receiver.go localhost:5672/example
    Receiver listened on the '/example' address instead of 'example'
    
    Also adjusted the receiver and sender examples to use url.Address() instead 
of passing url.Path.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mastash3ff/qpid-proton amqpAddressMethod

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #103
    
----
commit 1c246239789e91666353dd604ce64ce7b368eca3
Author: Brandon Sheffield <brandon>
Date:   2017-04-19T16:50:24Z

    Added Address() function to return an AMQP address.  Previous 
implementation relied on URL.Path to
    get an AMQP address.  This had the unintended consequence of returning 
addresses with '/' prepended.

commit 7b140d83786b7ed5ee3122a819e7f17f571143a0
Author: Brandon Sheffield <brandon>
Date:   2017-04-19T16:55:43Z

    adjusted Receivers to take address string instead of url.Path string that 
added an unnecessary slash character to address

----


> Golang AMQP URL incompatable with Qpid Cpp Broker.  Node not found: /address 
> when using Qpid C++ Broker
> -------------------------------------------------------------------------------------------------------
>
>                 Key: PROTON-1463
>                 URL: https://issues.apache.org/jira/browse/PROTON-1463
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: go-binding
>    Affects Versions: 0.17.0
>            Reporter: Brandon W Sheffield
>            Assignee: Alan Conway
>
> Go examples not compatible with Qpid C++ broker version 1.36.
> With qpidd running as a daemon, running the go "receive" binary example with 
> no address will work:
> ./receive localhost:5672
> Listening on 1 connections
> But if provided a address, will get error:
> ./receive localhost:5672/address
> Listening on 1 connections
> 2017/04/18 13:30:54 receive error %v: %vlocalhost:5672/addressamqp:not-found: 
> Node not found: /address
> Qpid C++ Broker spits out error:
> [Protocol] error Error on attach: Node not found: /address
> Does not behave like this when using the provided Go example broker binary 
> instead of Qpid C++ broker.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to