[
https://issues.apache.org/jira/browse/QPID-7815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050499#comment-16050499
]
Lorenz Quack commented on QPID-7815:
------------------------------------
Following the
[discussion|https://mail-archives.apache.org/mod_mbox/qpid-users/201706.mbox/%[email protected]%3e]
on [email protected] I think the patch should be modified to not apply the
policy to existing messages. Only to newly arriving messages.
This should simplify the path.
* You no longer need the {{Queue#getNewestEntry()}}.
* You no longer need the loop in the policy handler.
Special attention should be payed to [Robbies comment on the discussion
thread|https://mail-archives.apache.org/mod_mbox/qpid-users/201706.mbox/%3cCAFitrpT=tNGhdV_PPxH36DJSfVLwrt0kdfTZfwQtJojfeuGQ=q...@mail.gmail.com%3e]:
bq. One last thought: if the queue is overfull with persistent messages
following the reconfiguration, and the broker is restarted, what happens to the
queue during recovery?
The policy should not apply to recovered messages. I think this can be achieved
by only applying the policy in case the session principal is present.
Could you check why the patched QueuePolicyTest is failing on 0-9 and 1.0?
> Reject policy type
> ------------------
>
> Key: QPID-7815
> URL: https://issues.apache.org/jira/browse/QPID-7815
> Project: Qpid
> Issue Type: New Feature
> Components: Java Broker
> Affects Versions: qpid-java-broker-7.0.0
> Reporter: Tomas Vavricka
> Assignee: Lorenz Quack
> Labels: policy-type, queue, reject
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7815-Java-Broker-Enable-QueuePolicyTests-on-all.patch,
> 0001-QPID-7815-Reject-policy-type.patch
>
>
> It would be good if Java Broker will support reject policy.
> Reject policy - reject incoming message(s) when queue capacity is reached
> Queue capacity can be defined by maximum count of message and maximum size of
> messages (including header).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
