[
https://issues.apache.org/jira/browse/QPID-7815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057350#comment-16057350
]
Lorenz Quack commented on QPID-7815:
------------------------------------
Hi Tomas,
I have a couple more comments:
* I meant to apply the caching of the {{AccessController.getContext()}} to the
loop not across method calls. Now that the loop is gone the point is moot.
* In the {{RejectOverflowPolicyHandler}} logging happens even if no rejection
happened (i.e. recovery case or operator intervention). The logging code could
actually move into the above
if-statement. No point in keeping it separate. To make sure this logging
does also not happen in the recovery case it should move into the inner most
level next to the actual call to {{session.reject()}}.
* In RejectOverflowPolicyHandler the if-statements {{if (bytesOverflow ||
messagesOverflow)}} and {{if (newlyEnqueued != null)}} can be collapsed into
one.
* We prefer single class imports over package.* imports.
* Thinking about it again, on AMQP 1.0 we should really at most Detach the
Link. I don't see a reason to End the Session much less in Closing the
Connection. In the other protocols we do not have this level of granularity so
we have to close the session(0-10)/channel(0-9). If the test fail because of
this, my guess would be that the tests are in error.
* The dependency on the qpid-jms-client you added to the {{pom.xml}} should not
be needed. You can run the systests like this: {{mvn verify -P java-mms.1-0
-DenableAmqp1-0}} That will automatically pull in the correct dependency (see
bottom of the same pom.xml).
* Channel_logmessages.properties is missing a new line at the end of the file
* In the ManagedAttribute description of {{Queue#getOverflowPolicy}}. I would
talk about rejecting messages instead of discarding.
> Reject policy type
> ------------------
>
> Key: QPID-7815
> URL: https://issues.apache.org/jira/browse/QPID-7815
> Project: Qpid
> Issue Type: New Feature
> Components: Java Broker
> Affects Versions: qpid-java-broker-7.0.0
> Reporter: Tomas Vavricka
> Assignee: Lorenz Quack
> Labels: policy-type, queue, reject
> Fix For: qpid-java-broker-7.0.0
>
> Attachments:
> 0001-QPID-7815-Java-Broker-Enable-QueuePolicyTests-on-all.patch,
> 0001-QPID-7815-Reject-policy-type.patch
>
>
> It would be good if Java Broker will support reject policy.
> Reject policy - reject incoming message(s) when queue capacity is reached
> Queue capacity can be defined by maximum count of message and maximum size of
> messages (including header).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
