[ 
https://issues.apache.org/jira/browse/DISPATCH-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100124#comment-16100124
 ] 

ASF GitHub Bot commented on DISPATCH-767:
-----------------------------------------

Github user ChugR commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/177#discussion_r129306348
  
    --- Diff: include/qpid/dispatch/message.h ---
    @@ -296,6 +296,61 @@ qd_parsed_field_t *qd_message_get_trace      
(qd_message_t *msg);
      */
     int                qd_message_get_phase_val  (qd_message_t *msg);
     
    +/*
    + * Should the message be discarded.
    + * A message can be discarded if the disposition is released or rejected.
    + *
    + * @param msg A pointer to the message.
    + **/
    +bool qd_message_is_discard(qd_message_t *msg);
    +
    +/**
    + *Set the discard field on the message to to the passed in boolean value.
    + *
    + * @param msg A pointer to the message.
    + * @param discard - the boolean value of discard.
    + */
    +void qd_message_set_discard(qd_message_t *msg, bool discard);
    +
    +/**
    + * Has the message been completely received?
    + * Return true if the message is fully received
    + * Returns false if only the partial message has been received, if there 
is more of the message to be received.
    + *
    + * @param msg A pointer to the message.
    + */
    +bool qd_message_receive_complete(qd_message_t *msg);
    +
    +/**
    + * Returns true if the message has been completely received AND the 
message has been completely sent.
    + */
    +bool qd_message_send_complete(qd_message_t *msg);
    +
    +/**
    + * Returns true if the delivery tag has already been sent.
    + */
    +bool qd_message_tag_sent(qd_message_t *msg);
    +
    +
    +/**
    + * Returns true if the delivery tag has already been sent.
    --- End diff --
    
    cut-paste issue. This function sets something and returns nothing.


> Message Cut-Through/Streaming for efficient handling of large messages
> ----------------------------------------------------------------------
>
>                 Key: DISPATCH-767
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-767
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Router Node
>            Reporter: Ted Ross
>            Assignee: Ganesh Murthy
>             Fix For: 1.0.0
>
>
> When large, multi-frame messages are sent through the router, there is no 
> need to wait for the entire message to arrive before starting to send it 
> onward.
> This feature causes the router to route the first frame and allow subsequent 
> frames in a delivery to be streamed out in pipeline fashion.  Ideally, the 
> memory usage in the router should only involve pending frames.  This would 
> allow the router to handle arbitrary numbers of concurrent arbitrarily large 
> messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to