Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/185#discussion_r132260270
  
    --- Diff: src/router_core/connections.c ---
    @@ -1300,9 +1310,15 @@ static void 
qdr_link_inbound_first_attach_CT(qdr_core_t *core, qdr_action_t *act
                     //
                     // This link has a target address
                     //
    -                bool           link_route;
    -                qdr_address_t *addr = qdr_lookup_terminus_address_CT(core, 
dir, conn, target, true, true, &link_route);
    -                if (!addr) {
    +                bool  link_route;
    +                bool  forbidden;
    +                qdr_address_t *addr = qdr_lookup_terminus_address_CT(core, 
dir, conn, target, true, true, &link_route, &forbidden);
    +                if (forbidden) {
    +                    qdr_link_outbound_detach_CT(core, link, 0, 
QDR_CONDITION_FORBIDDEN, true);
    --- End diff --
    
    Does this do the right thing protocol-wise?  Does the router send an attach 
with NULL terminus followed by a detach?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to