Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/185#discussion_r132261405
  
    --- Diff: src/router_core/transfer.c ---
    @@ -634,6 +634,23 @@ static void qdr_link_forward_CT(qdr_core_t *core, 
qdr_link_t *link, qdr_delivery
                 addr->deliveries_ingress++;
             link->total_deliveries++;
         }
    +    //
    +    // There is no address that we can send this delivery to, which means 
the addr was not found in our hastable. This
    +    // can be because there were no receivers or because the address was 
not defined in the config file.
    +    // If the treatment for such addresses is set to be forbidden, we send 
back a rejected disposition and detach the link
    +    //
    +    else if (core->qd->treatment == QD_TREATMENT_LINK_FORBIDDEN) {
    +        dlv->disposition = PN_REJECTED;
    +        dlv->error = qdr_error("qd:forbidden", "Sending deliveries to this 
address is forbidden");
    --- End diff --
    
    You should be using one of the AMQP-specified error conditions that is in 
the amqp.[ch] files.  It seems that the appropriate error condition is 
"amqp:not-allowed", not "forbidden" (which is an error code only for the 
management protocol).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to