[
https://issues.apache.org/jira/browse/PROTON-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215003#comment-16215003
]
Alan Conway edited comment on PROTON-1622 at 10/23/17 11:58 AM:
----------------------------------------------------------------
I like the idea but it's not working for me - don't see any compile flags
(-ftest-coverage -fprofile-arcs) to enable coverage counts and when I run with
-DCMAKE_BUILD_TYPE=Coverage I can't find any coverage results. Maybe something
got left out?
A couple of other minor suggestions:
- no need for bin/python-m-coverage.sh, just call python directly with the
extra args from cmake.
- suggest you disable valgrind automatically for Coverage builds - like you did
for the sanitizers.
- do you need lcov only or both lcov and gcov in travis? I don't know, just
checking if its deliberate or an oversight.
Otherwise this is great, the sooner we get it in, the better.
was (Author: aconway):
I like the idea but it's not working for me - don't see any compile flags
(-ftest-coverage -fprofile-arcs) to enable coverage counts and when I run with
-DCMAKE_BUILD_TYPE=Coverage I can't find any coverage results. Maybe something
got left out?
A couple of other minor suggestions:
- no need for bin/python-m-coverage.sh, just call python directly with the
extra args from cmake.
- suggest you disable valgrind automatically for Coverage builds - like you did
for the sanitizers.
- do you need lcov only or both lcov and gcov in travis? I don't know, just
checking if its deliberate or an oversight.
Otherwise this is great, the sooner we get it in, the better.
> Add coverage reporting to CMake build
> -------------------------------------
>
> Key: PROTON-1622
> URL: https://issues.apache.org/jira/browse/PROTON-1622
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-c-0.18.0
> Reporter: Jiri Daněk
> Assignee: Justin Ross
> Priority: Minor
> Labels: patch, testing
> Fix For: proton-c-0.19.0
>
>
> This improvement is intended to cover
> * Reporting coverage from Python code
> * Upload of Python and C/C++ coverage data from Travis CI to codecov.io for
> easy viewing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
