[ 
https://issues.apache.org/jira/browse/PROTON-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215133#comment-16215133
 ] 

Alan Conway edited comment on PROTON-1622 at 10/23/17 2:24 PM:
---------------------------------------------------------------

It works!!! A minor issues that confused me: there is a 'make coverage' target 
in cmake that doesn't work. Easy to fix, and I think this is good to go - shall 
I commit or do you have anything to add?

The coverage report is very useful, I fear I have a lot of test writing to do 
in the near future....



was (Author: aconway):
It works!!! A minor issues that confused me: there is a 'make coverage' target 
in cmake that doesn't work.  I would fix that to run the tests, call the 
coverage scripts, create the coverage_results dir and put the results there. 
That would make it easy to run on your own build as well as via travis.

The coverage report is very useful, I fear I have a lot of test writing to do 
in the near future....


> Add coverage reporting to CMake build
> -------------------------------------
>
>                 Key: PROTON-1622
>                 URL: https://issues.apache.org/jira/browse/PROTON-1622
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>    Affects Versions: proton-c-0.18.0
>            Reporter: Jiri Daněk
>            Assignee: Justin Ross
>            Priority: Minor
>              Labels: patch, testing
>             Fix For: proton-c-0.19.0
>
>
> This improvement is intended to cover
> * Reporting coverage from Python code
> * Upload of Python and C/C++ coverage data from Travis CI to codecov.io for 
> easy viewing



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to